Temporarily disable scan tests, re-enable tests on gfx11xx #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
Remove code that excludes gfx11xx tests on Jenkins, since they work there now. Add a temporary exclusion for test_thrust_scan, which needs a compiler fix.
umfranzw
force-pushed
the
disable_scan_test
branch
from
1103aeb
to
8b6d20d
Compare
|
The build failures seem to indicate that CMake is using an outdated version of Google benchmark. I've addressed that problem in this separate PR: #450 |
stanleytsang-amd
approved these changes
Aug 22, 2024
.jenkins/common.groovy
Outdated
| excludeRegex = /(reduce_by_key.hip|partition.hip|sort.hip|sort_by_key.hip|stable_sort_by_key.hip|stable_sort.hip|async_copy.hip|async_reduce.hip|async_scan.hip|async_sort.hip|async_transform.hip)/ | ||
| } | ||
| // Note: temporarily disable test_thrust_scan below while waiting for a compiler fix | ||
| def excludeRegex = /(reduce_by_key.hip|test_thrust_scan)/ |
There was a problem hiding this comment.
Can we try re-enabling reduce_by_key.hip for all architectures? I can't remember the circumstances that required its exclusion in the first place, but most likely the test is fine now.
stanleytsang-amd
merged commit 769c779
into
ROCm:release-staging/rocm-rel-6.3
16 of 20 checks passed
umfranzw
added a commit
that referenced
this pull request
Sep 19, 2024
* Remove Thrust comments referencing website (#451) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Specify minimum version for Google benchmark (#450) * Remove Thrust comments referencing website (#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Bump rocm-docs-core from 1.6.2 to 1.7.1 in /docs/sphinx (#448) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.6.2 to 1.7.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.6.2...v1.7.1) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Specify minimum version for Google benchmark Pass a minimum version to find_package to prevent it from using outdated versions of Google benchmark that may be present on the system. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Temporarily disable scan tests, re-enable tests on gfx11xx (#449) * Remove Thrust comments referencing website (#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Temporarily disable scan tests, re-enable tests on gfx11xx Remove code that excludes gfx11xx tests on Jenkins, since they work there now. Add a temporary exclusion for test_thrust_scan, which needs a compiler fix. * Remove website URL from comments (#456) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Add checks around some platform-specific benchmark code (#455) There were two spots in the new benchmark code that were causing compile-time issues on some Windows systems. This change adds a check to make sure we have 128-bit integer support before using int128_t in generation_utils.hpp. It also avoids calling clock_gettime on Windows, since it seems to be causing build issues there. Instead, I've restored the old Windows timing code from PR #431, which uses QueryPerformanceFrequency/Counter instead. * Add gfx1151 build target (#457) (#459) * Add gfx1151 target * Revert "Add gfx1151 target" This reverts commit 5889238. * Add gfx1151 target while preserving address sanitizer targets --------- Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Remove website reference (#460) Removed the link to more information from the CRC algorithm comments. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code that excludes gfx11xx tests on Jenkins, since they work there now. Add a temporary exclusion for test_thrust_scan, which needs a compiler fix.